Skip to content

[REFACTOR] Preparation work related to LRN-49750#100

Merged
roger-marley-lrn merged 2 commits intomasterfrom
LRN-49750/refactor/remove-deprecated-code
Feb 3, 2026
Merged

[REFACTOR] Preparation work related to LRN-49750#100
roger-marley-lrn merged 2 commits intomasterfrom
LRN-49750/refactor/remove-deprecated-code

Conversation

@roger-marley-lrn
Copy link
Contributor

@roger-marley-lrn roger-marley-lrn commented Jan 28, 2026

Overview

  • Bumping PHP supported versions to those currently within "Security Support" term
  • Removing deprecated call that is causing deprecation notices in LP
  • Preparatory for later PHP upgrade related work, since this is a dependency of LP

Checklist

  • Feature

  • Bug

  • ChangeLog.md updated

  • Tests added

  • All testsuite passes

  • make dist completed successfully

@roger-marley-lrn roger-marley-lrn changed the title [REFACTOR] curl_close() removed - it's a no-op since PHP 8.0 [REFACTOR] Preparation work related to LRN-49750 Jan 28, 2026
@roger-marley-lrn roger-marley-lrn marked this pull request as draft January 28, 2026 04:24
@roger-marley-lrn roger-marley-lrn marked this pull request as ready for review January 28, 2026 04:28
@roger-marley-lrn
Copy link
Contributor Author

roger-marley-lrn commented Jan 28, 2026

hi @danny-beton-lrn, a minor one, but could I get this one merged and released as v1.2.1?
LP's has a dependency on this, and I'm doing some preparatory cleanup for LRN-49750

@roger-marley-lrn
Copy link
Contributor Author

(@danny-beton-lrn also I believe the ChangeLog.md needs updating, and wasn't in the v1.2.0 release - so I'll let you work out what's to go there)

Copy link
Contributor

@danny-beton-lrn danny-beton-lrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roger-marley-lrn roger-marley-lrn merged commit 0fecf34 into master Feb 3, 2026
2 checks passed
@roger-marley-lrn roger-marley-lrn deleted the LRN-49750/refactor/remove-deprecated-code branch February 3, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants