perf(#281): add configurable retry with jitter to submitTransaction - #358
Merged
BigBen-7 merged 2 commits intoJul 26, 2026
Merged
Conversation
…ransaction - Add SubmitTransactionOptions interface with maxRetries (default 3), retryDelayMs (default 1000), and maxPollAttempts (default 20) - Retry submission on RATE_LIMIT_EXCEEDED with ±20% random jitter to avoid thundering-herd collisions on concurrent submissions - Maintain backwards-compat: bare number still accepted as maxPollAttempts - Export SubmitTransactionOptions from src/index.ts - Fix pre-existing estimateFee bug (used tx/sourceAccount before declaration) - Fix pre-existing duplicate enum values in VeriTixErrorCode - Add tests: retry with options, RATE_LIMIT retries, exhausted retries, jitter bounds, default options, READ_ONLY_CLIENT guard Closes Lead-Studios#281
|
@Userhorlie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
This PR currently has merge conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable retry logic with ±20% random jitter to
submitTransactioninsrc/utils/transaction.tsto reduce Horizon 429 collisions when multiple clients retry simultaneously.Changes
SubmitTransactionOptionsinterface withmaxRetries(default 3),retryDelayMs(default 1000),maxPollAttempts(default 20)RATE_LIMIT_EXCEEDEDerrors, applying jitter:delay ± 20%ofretryDelayMsnumberstill accepted asmaxPollAttemptsSubmitTransactionOptionsfromsrc/index.tsestimateFee(referencedtx/sourceAccountbefore declaration)VeriTixErrorCodeTests
Added 6 new tests in
tests/utils/transaction.test.ts:maxRetriesandretryDelayMsvia options objectRATE_LIMIT_EXCEEDEDup tomaxRetriestimesmaxRetrieson persistent rate limitmaxRetriesto 3 when no options suppliedREAD_ONLY_CLIENTwhen no keypair providedCloses #281
Closes #282
Closes #283
Closes #285