Layr/make batched cache#2
Open
ronaldmannak wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchGenerator.makeBatchedCachewith explicit topology validation at init time. The previous code defaulted any unrecognizedKVCachesubclass toBatchKVCache, which silently produced incorrect caches for unsupported types.BatchedCacheList, a batched analog ofCacheList, so hybrid models that compose multiple caches per layer (e.g. Mamba + attention) preserve their per-layer topology under continuous batching.cacheParameters: GenerateParameters?argument toBatchGenerator.initso models that need cache-shaping options (e.g.maxKVSize) can receive them.Behavior changes
BatchGenerator.initis nowthrowsand rejects unsupported cache topologies up-front viaBatchGeneratorError.unsupportedCacheTopology, including the layer index, a path within the layer, the offending cache type, and a human-readable reason.QuantizedKVCache,ChunkedKVCache, andRotatingKVCacheconfigured with non-zero keep tokens, with type-specific error messages instead of a generic "no batched implementation" fallback.model.newCache(parameters:)call and re-classification.Swift.type(of:) == X.self) are used forMambaCache,ArraysCache, andKVCacheSimpleto avoid misclassifying subclasses (MambaCache : ArraysCache,ChunkedKVCache : KVCacheSimple).