feat: cloud report#8
Open
gpsanant wants to merge 8 commits into
Open
Conversation
solimander
reviewed
Nov 12, 2025
| } | ||
|
|
||
| /// @inheritdoc ICloudReportCompendium | ||
| function slash(bytes calldata eigendaCert) external { |
Contributor
There was a problem hiding this comment.
need to enforce:
a max of
SLASH_AMOUNTEIGEN can be slashed perLIVENESS_INTERVAL
solimander
reviewed
Nov 13, 2025
| require(bytes20(keccak256(eigendaCert)) == _latestReportSubmission.eigendaCertHash, InvalidCertificate()); | ||
|
|
||
| string memory reason; | ||
| if (block.timestamp - _latestReportSubmission.submissionTimestamp >= reportFreshnessThreshold) { |
Contributor
There was a problem hiding this comment.
should also validate the freshness of the report itself. if the last attested state only covered time T and several slashing intervals pass, submitting a report that still only covers that stale window shouldn’t satisfy liveness or prevent slashing
solimander
reviewed
Nov 13, 2025
| import {CloudReportCompendiumStorage} from "./storage/CloudReportCompendiumStorage.sol"; | ||
| import {ICloudReportCompendium} from "./interfaces/ICloudReportCompendium.sol"; | ||
|
|
||
| contract CloudReportCompendium is |
Contributor
There was a problem hiding this comment.
who is the proxy admin? ops multisig behind a timelock?
Contributor
There was a problem hiding this comment.
same for the admin setter functions below?
Contributor
what did you have in mind for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.