feat: duration vaults #1671
feat: duration vaults #1671
Conversation
ypatil12
left a comment
ypatil12
left a comment
There was a problem hiding this comment.
Looks good! General state machine + readability improvements. Big question is still around guarantees we need around staker delegation at the time of deposit.
| require(!isBlacklisted[underlyingToken], BlacklistedToken()); | ||
| require(address(durationVaultBeacon) != address(0), DurationVaultBeaconNotSet()); | ||
|
|
||
| newVault = IDurationVaultStrategy( |
There was a problem hiding this comment.
Do we want these to be deterministic deploys?
| address newVaultAdmin | ||
| ) external; | ||
|
|
||
| function vaultAdmin() external view returns (address); |
There was a problem hiding this comment.
Instead of vaultAdmin, is it worth just inheriting Ownable? Reduces the surface area of code IMO.
There was a problem hiding this comment.
Do we want it to be transferable?
There was a problem hiding this comment.
Don't think we need it to be transferrable? Fine to just leave as an immutable at deploy
| address newVaultAdmin | ||
| ) external; | ||
|
|
||
| function vaultAdmin() external view returns (address); |
There was a problem hiding this comment.
Don't think we need it to be transferrable? Fine to just leave as an immutable at deploy
| * @notice Locks the vault, preventing new deposits and withdrawals until maturity. | ||
| */ | ||
| function lock() external override onlyVaultAdmin { | ||
| require(_state == VaultState.Deposits, VaultAlreadyLocked()); |
There was a problem hiding this comment.
Do we want a startTime for the vault? Unsure what the user story is for when the vault can begin allocation
There was a problem hiding this comment.
Having a unique start time per vault enables each vault to have a deterministic deployment... again unsure if that's a relevant user story
There was a problem hiding this comment.
We used to have defined deposit windows but removed to make things easier for AVSs. Insurance AVS can lock at an arbitrary time but it's expected they will say publicly
| string calldata newMetadataURI | ||
| ) external override onlyVaultAdmin { | ||
| metadataURI = newMetadataURI; | ||
| emit MetadataURIUpdated(newMetadataURI); |
There was a problem hiding this comment.
How does the metadataURI here differ from the operator metadataURI. Do we need two different ones? Also, do we have a plan for how the UI will look with these vault Strats?
There was a problem hiding this comment.
metadataURI would just describe the vault properties. It would be the same as operator metadataURI, but I liked the idea of it being tied to the strategy contract directly rather than indirectly through it registering as an operator
Motivation:
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.