feat: slashing hotfix v1.1.1 #1122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due to
devhaving changes not pushed to testnet, this hotfix will be based off the latest release on testnetv1.0.3.#1102 #1103
This hotfix will address registries being used for different AVSs as well as inaccurate gas estimations for deregistering (due to the try catch)
Modifications:
address avsfield in calldata ofIAVSRegistry.registerOperator,IAVSRegistry.deregisterOperatorIAVSRegistry.supportsAVS(avs)interface which is checked upon setting an AVS registry.Result:
Operator deregistration will be a atomic interaction between the core and AVS contracts with the try/catch being removed.
There are now additional checks on the AVS registry being set to prevent registries being used without consent for multiple AVSs. The
address avsfield should also be verified by AVSs upon callbacks.Note: I created the branch
1.0.3which is based off the same commit of the release tag so that a PR can be made for this updated script. This branch can be deleted later on after the audit fixes upgrade has gone through