Add P2P SC deposit relay integration test, refactor stock bitcoin core - #626
Merged
Merged
Conversation
torkelrogstad
force-pushed
the
2026-09-11-standardness
branch
from
September 16, 2026 16:30
01c9228 to
6316482
Compare
Add an integration test demonstrating P2P relay of sidechain deposit transactions. Refactor handling of stock Bitcoin Core in tests. Remove usage of `-acceptnonstdtxn` to clearly demonstrate which tests fail without this. Update the skip list accordingly. Make it possible to force running tests against a Bitcoin Core version, by ignoring the skip list when specific args are passed. I.e. the following test would run (and fail): ``` $ just test-it --bitcoind unpatched peer_deposit_relay ```
torkelrogstad
force-pushed
the
2026-09-11-standardness
branch
from
September 16, 2026 17:49
6316482 to
64f8d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an integration test demonstrating P2P relay of sidechain deposit
transactions.
Refactor handling of stock Bitcoin Core in tests. Remove usage of
-acceptnonstdtxnto clearly demonstrate which tests fail without this.Update the skip list accordingly.
Make it possible to force running tests against a Bitcoin Core version,
by ignoring the skip list when specific args are passed. I.e. the
following test would run (and fail):