Open
Conversation
added input validation, graceful shutdown, and structured JSON proof - Added error handling for user input with `bufio.ReadString`. - Wrapped proof data in a JSON struct for clarity and future extensibility. - Replaced `fmt.Printf` with structured `log.Printf` for consistent logging. - Made endpoint configurable via `PROOF_ENDPOINT` environment variable. - Added graceful shutdown on SIGINT (Ctrl+C). - Used a `select` with timeout for non-blocking channel send.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the resilience and maintainability of the proof submission CLI tool. Key updates include:
-Structured error handling for user input and channel operations.
-JSON formatting of proof data for better interoperability and debugging.
-Graceful shutdown handling via OS signals (e.g., Ctrl+C).
-Configuration of the endpoint via an environment variable (PROOF_ENDPOINT).
-Consistent logging with log.Printf instead of fmt.Printf.
These changes make the codebase safer, cleaner, and easier to deploy in real-world environments.