Add JTE support, add QJniObject templates #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator Done initially for this in generatorHeader().
This allows saner reuse of them in other functions.
Remove the codeResolver member, make it local to init {}, and
use a lateinit var for templateEngine.
This allows us to do templating by just passing the HandyHelper to the templates.
The mac line endings end up in an unreadable file everywhere (except on Mac, of course).
…s not assigned to JteData
Id Declarations
Templates
The newline continuations were wrong, the @if was adding newlines.
Licence update
This also changes NativeProxyGenerator a bit: 1) There is now an additional header_final_postamble template used. This allows generating a header guard. 2) The handling of jte exceptions no longer swallows the exception, its data is now printed. Other than that, we add a new android sample, which uses the QJniObject templates. The first part of that is adding a data member, and the <QJniObject> include, no other changes yet, other than the use of an include guard instead of a #pragma once.
These get our demo to a compiling and running state (with adjustments) Method definitions are not quite right atm wrt. static. Fixing that next.
… into dev Change-Id: I9f86ac683c8e09a26947234d0969930d4b44bd2a
Change-Id: I4109a65d23748e2b2c8fd9d8d2701c331c77bc98 Reviewed-by: Assam Boudjelthia <[email protected]>
…t conversion to a JNI type Change-Id: I1c6970a9eaa5a15d2437c4455f1c04d33d9a2e74 Reviewed-by: Assam Boudjelthia <[email protected]>
Author
There was a problem hiding this comment.
Feel free to ignore commit b907f0a, it's been undone in a later commit.
Change-Id: Ia33095c343ede539afabc902d4c4c4ff8086f8d2 Reviewed-by: Assam Boudjelthia <[email protected]>
This fixes our longest-standing problem; when run in parallel, the build sometimes (often) fails, because parallel builds cause JTE to write to the same java class files concurrently. The problem is cured by defining a task-specific property that is then passed down to Jenny as the directory suffix to use for the JTE output directory. Change-Id: I1f49a3af7f8d1102dc06cc1705c0ff1868477568 Reviewed-by: Assam Boudjelthia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add templating support, add templates for both the "built-in" code generation, and also for generating classes that use QJniObject.