Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate triggerarea zoning check #6963

Merged

Conversation

StabbyCutyou
Copy link
Contributor

@StabbyCutyou StabbyCutyou commented Feb 6, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Follows up on this outstanding issue from PR #6946

Steps to test these changes

Login while having logged out in a trigger zone
Notice that the trigger zone takes effect once you have "zoned in"
Ex: NPCs for the Flyers for Regine quest will look at you upon logging in

Prior to this, after the changes in the original PR, the lua would not have run but your character would still be marked as being inside the trigger area.

Notes

Following up here: here

Zoning into Abyssea - Konschtat has the visitant status message appear.
Logging out and back in also has the message appear.

Copy link
Member

@WinterSolstice8 WinterSolstice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty old bug. If you really want to make sure it nails a well known bug dead, try !zone empyreal paradox and see if it shows the CS to use the teleporter

@StabbyCutyou
Copy link
Contributor Author

Yea sure, let me give it a whirl

@StabbyCutyou
Copy link
Contributor Author

StabbyCutyou commented Feb 6, 2025

Sure enough, upon logging in, I get the event which activates the prompt to teleport. It was a little slow to happen, but it did happen.

https://imgur.com/a/VOwGLGV

Also, upon logging in again after logging out in Abyssea having not obtained visitant status, my timer was reset to 5 minutes. I think clay alluded to an issue with this, but I honestly do not remember how retail worked in that regard, nor am I sure if my change resulted in that behavior.

@WinterSolstice8
Copy link
Member

Excellent. As for the no-visitant status resetting to 5 minutes I think that is a minor bug. Not very exploitable compared to retail when you can just enter/exit repeatedly anyway. As long as you cant move past the barriers its not a big deal

@StabbyCutyou
Copy link
Contributor Author

When I ran past the barriers, I got a 10 second warning - twice.

But the rest of the countdown happened normally, and I was warped back behind them a bit when it completed.

@WinterSolstice8
Copy link
Member

yeah thats a bit out of scope for this thankfully. long as it works

@zach2good zach2good merged commit c096b9c into LandSandBoat:base Feb 6, 2025
14 checks passed
@StabbyCutyou StabbyCutyou mentioned this pull request Feb 8, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants