Skip to content

Add UART transmitter#62

Open
KubEF wants to merge 35 commits into
mainfrom
uart
Open

Add UART transmitter#62
KubEF wants to merge 35 commits into
mainfrom
uart

Conversation

@KubEF
Copy link
Copy Markdown
Contributor

@KubEF KubEF commented Mar 2, 2026

  • Black box wrapper for UART Master IP-core
  • Helper functions for iteration over ram by bytes
  • Script for build and synthesis
  • Implement UART transmitter in the main circuit

@KubEF KubEF requested a review from gsvgit March 2, 2026 22:09
Copy link
Copy Markdown
Member

@gsvgit gsvgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start adding comments to the code, at least with a description of each file's content and purpose.

Comment thread lamagraph-core/README.md Outdated
Comment thread lamagraph-core/README.md Outdated
Comment thread lamagraph-core/package.yaml Outdated
Comment thread lamagraph-core/gprj-processor.sh
set_option -top_module topEntity
set_option -verilog_std sysv2017

# add_file -type verilog ../lamagraph-core/hdl/systemverilog/Core.Core.topEntity/topEntity.sv
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these lines necessary?

@@ -0,0 +1,37 @@
{-# LANGUAGE MultiParamTypeClasses #-}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be moved to tests?

Comment thread lamagraph-core/src/Protocols/Uart/Helper.hs
@@ -0,0 +1 @@
((S(K((S(K((S(KS))K)))((S(KS))K))))(S(K((S(K((S(KS))K)))((S(KS))K)))))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add readme with brief description of tests. I guess that these are well-known examples for SKI, but it may be not do obvious.

@@ -0,0 +1,25 @@
import qualified Clash.Prelude as C
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start adding comments to the code, at least with a description of each file's content and purpose.

@@ -1,6 +1,217 @@
{-# LANGUAGE UndecidableInstances #-}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it app? Not test or demo.

@KubEF KubEF requested a review from gsvgit March 3, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants