Skip to content

Add test for update_fee_config NotInitialized path#984

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
Benedict315:test/update-fee-config-not-initialized
Jul 3, 2026
Merged

Add test for update_fee_config NotInitialized path#984
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
Benedict315:test/update-fee-config-not-initialized

Conversation

@Benedict315

Copy link
Copy Markdown
Contributor

Description

Summary: Adds a test to cover the previously untested NotInitialized error path in the update_fee_config function.

Changes:

Added test_update_fee_config_rejects_not_initialized test in test.rs
The test calls try_update_fee_config before initialize and asserts that it returns Err(Ok(StreamError::NotInitialized))
Context: The update_fee_config function calls load_config(&env) at line 90 in lib.rs, which returns StreamError::NotInitialized when called before initialize. While this error path was already tested once via transfer_admin, there was no specific test calling update_fee_config on an uninitialized contract.

Testing:

Test passes: test_update_fee_config_rejects_not_initialized ... ok
closes #792

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meaningful test: try_update_fee_config on an uninitialized contract asserts Err(NotInitialized) not a panic (update_fee_config hits load_config()? before the auth-gated logic), and it's not a duplicate of the existing NotInitialized test. cargo test green (98). merging.

@ogazboiz ogazboiz merged commit abf657a into LabsCrypt:main Jul 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] update_fee_config NotInitialized path is never tested

3 participants