Pr 946 clean#978
Merged
Merged
Conversation
19 tasks
ogazboiz
approved these changes
Jul 4, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
verified the docs against the source: error codes 1-11 match errors.rs, all 11 event topics match events.rs, the fee-collection points and the rounding-to-zero example are accurate, and the lib.rs change is doc-only (include_str + one collect_fee doc comment). builds + tests pass. merging as the clean, contracts-only version of #946.
two tiny doc nits for a follow-up: the StreamError table omits code 12 StreamPaused, and InvalidRate is net_amount/duration (post-fee) not amount/duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #798
Created
pr-946-cleanfromupstream/mainand cherry-picked only the intended PR 946 commits:Notes
Request
Please review this clean branch and merge once CI is green.