Skip to content

Pr 946 clean#978

Merged
ogazboiz merged 2 commits into
LabsCrypt:mainfrom
Killerjunior:pr-946-clean
Jul 4, 2026
Merged

Pr 946 clean#978
ogazboiz merged 2 commits into
LabsCrypt:mainfrom
Killerjunior:pr-946-clean

Conversation

@Killerjunior

Copy link
Copy Markdown
Contributor

Summary

Closes #798

Created pr-946-clean from upstream/main and cherry-picked only the intended PR 946 commits:

  • Added README.md
  • Added crate description in Cargo.toml
  • Wired crate docs in lib.rs
  • Added regression test in test.rs

Notes

  • The original branch included unrelated frontend/backend history.
  • This clean branch contains only the actual PR changes.
  • Dockerfile and soroban-event-worker.ts were not modified in this new branch.

Request

Please review this clean branch and merge once CI is green.

@Killerjunior Killerjunior mentioned this pull request Jul 1, 2026
19 tasks

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified the docs against the source: error codes 1-11 match errors.rs, all 11 event topics match events.rs, the fee-collection points and the rounding-to-zero example are accurate, and the lib.rs change is doc-only (include_str + one collect_fee doc comment). builds + tests pass. merging as the clean, contracts-only version of #946.

two tiny doc nits for a follow-up: the StreamError table omits code 12 StreamPaused, and InvalidRate is net_amount/duration (post-fee) not amount/duration.

@ogazboiz
ogazboiz merged commit 8cf5d81 into LabsCrypt:main Jul 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] stream_contract crate has no README documenting public API, events, errors, and fee model

2 participants