Skip to content

test: add regression test for indexer cursor advancing past failed ev… - #1070

Open
extolkom wants to merge 4 commits into
LabsCrypt:mainfrom
extolkom:test/846-indexer-per-event-failure-cursor
Open

test: add regression test for indexer cursor advancing past failed ev…#1070
extolkom wants to merge 4 commits into
LabsCrypt:mainfrom
extolkom:test/846-indexer-per-event-failure-cursor

Conversation

@extolkom

Copy link
Copy Markdown
Contributor

closes #846

Added regression test cursor_does_not_advance_past_failed_event_in_mixed_batch to backend/tests/soroban-event-worker.test.ts.

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the core worker fix is right: the hasError flag freezing the cursor at the last pre-failure event and skipping the latestCursor fallback on error is exactly what #846 needs, and the regression test is solid. but the PR is bigger than its title:

  1. drop the unrelated changes: contracts test.rs formatting, the create-stream-content.tsx StrKey import rewrite, and the test-env retry knobs in useIncomingStreams.ts (the last collides with #996 and #1001).
  2. restore the removed toHaveBeenCalledTimes(1) assertion in pause-resume.regression.test.ts, or explain why it is now wrong; as it stands the #804 guard got weaker.
  3. rebase and re-run now that main is green.

if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] Indexer per-event failure path (batch continues, cursor advances past failed event) has no test

2 participants