Test coverage for Server JavaScript Console#2465
Conversation
labkey-jeckels
requested review from
a team,
labkey-chrisj,
labkey-matthewb and
labkey-susanh
and removed request for
a team
labkey-chrisj
left a comment
labkey-chrisj
left a comment
There was a problem hiding this comment.
Thanks for adding coverage to this!
|
@labkey-tchad @labkey-danield @labkey-chrisj this coverage is intended to make sure that the early startup logging from Spring Boot and our embedded Tomcat code is captured in |
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
We should use the actual Server JavaScript Console menu item to make sure it works correctly.
| // Check to see that the logging shows up in the Server JavaScript Console | ||
| // It's normally accessed via the developer menu, but we can hit the URL directly to avoid dealing with the | ||
| // popup window in the test |
There was a problem hiding this comment.
If this is the only test that touches the sessionLogging page, we should use the menu to ensure that it works correctly.
There was a recent refactor that made the RStudio item in the developer menu not open in a new window (fixed in LabKey/platform@080df3a).
There was a problem hiding this comment.
OK. Check out my latest commit. It's passing locally for me. Queued on TeamCity. https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyCPostgres/3539731
5 participants
Rationale
We've never tested the server-side JavaScript log display in Developer->Server JavaScript Console. It's time.
Related Pull Requests
Changes