Skip to content

Conversation

@github-actions
Copy link

Automatic merge failed! Please merge 24.7 into 24.11_fb_bot_merge_24.7 and resolve conflicts manually.

git fetch
git checkout 24.11_fb_bot_merge_24.7
git reset --hard origin/release24.11-SNAPSHOT
git merge e4c192032d85d07ee806c66611a5b2d83f1397da -m "Merge 24.7 to 24.11"

Resolve all conflicts (using IntelliJ or git mergetool)

git commit
git push --force

Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=24.11_fb_bot_merge_24.7

* Set qcTraceName on ChromatogramGroupId.

* Fix error importing Skyline documents with Spectrum Filters (#921)

"Spectrum Filter" gets parsed from the Skyline document
light:heavy ratios are not calculated for precursors that have a spectrum filter
The spectrum filter is used when deciding which chromatogram to read from the .skyd file for a particular precursor.
# Conflicts:
#	src/org/labkey/targetedms/parser/ChromatogramGroupId.java

* Added constructor for ChromatogramGroupId that takes both qcTraceName and spectrumFilter.

---------

Co-authored-by: nickshulman <[email protected]>
@labkey-sweta labkey-sweta reopened this Nov 25, 2024
@github-actions github-actions bot merged commit 651e69a into release24.11-SNAPSHOT Nov 25, 2024
2 checks passed
@github-actions github-actions bot deleted the 24.11_fb_bot_merge_24.7 branch November 25, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants