Skip to content

Handle timezone correctly during saving qc annotation #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankurjuneja merged 3 commits into from
Jan 15, 2026
+11 −4
Merged

Handle timezone correctly during saving qc annotation #1163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28d376a
Handle timezone correctly during saving qc annotation
ankurjuneja Jan 10, 2026
0d70a9d
try this change
ankurjuneja Jan 12, 2026
889a3db
try this
ankurjuneja Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions webapp/TargetedMS/js/QCTrendPlotPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,7 +1972,7 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
},

openAnnotationDialog: function (addNew, data) {
const date = this.formatDate(new Date(data['Date']), false);
const date = this.formatDate(data['Date'], false);
const title = addNew ? 'Add Annotation' : 'Edit Annotation';
const me = this;

Expand Down Expand Up @@ -2019,7 +2019,8 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
name: 'annotationDate',
format: 'Y-m-d',
allowBlank: false,
value: date
value: date,
submitFormat: 'Y-m-d'
}],

buttons: [{
Expand Down Expand Up @@ -2081,13 +2082,16 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
},

saveAnnotation: function (annotationType, description, annotationDate, win) {
// Format date as UTC string (YYYY-MM-DD) to avoid timezone conversion
const dateStr = Ext4.util.Format.date(annotationDate, 'Y-m-d');

LABKEY.Query.insertRows({
schemaName: 'targetedms',
queryName: 'QCAnnotation',
rows: [{
QCAnnotationTypeId: annotationType,
Description: description,
Date: annotationDate
Date: dateStr
}],
success: function () {
win.close();
Expand All @@ -2109,14 +2113,17 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
},

updateAnnotation: function (annotationId, annotationType, description, annotationDate, win) {
// Format date as UTC string (YYYY-MM-DD) to avoid timezone conversion
const dateStr = Ext4.util.Format.date(annotationDate, 'Y-m-d');

LABKEY.Query.updateRows({
schemaName: 'targetedms',
queryName: 'QCAnnotation',
rows: [{
Id: annotationId,
QCAnnotationTypeId: annotationType,
Description: description,
Date: annotationDate
Date: dateStr
}],
success: function () {
win.close();
Expand Down