Fix problems closing ResultSets #7328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
changed the title
Contributor
Author
|
Running the Compliance suite with the fixes: |
Contributor
Author
|
Suites are now passing, aside from unrelated failures. |
labkey-susanh
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
As part of upgrading to Java 25, we removed
finalize()methods and switched toCleaner, including inResultSetImpl. That didn't work forGroupedResultSetused for nested grid views in MS2 and TargetedMS, leading to a swath of test failures.This also caused failures in PHI logging as we were relying on calling
LoggingResultSetWrapper.close()Changes
ResultSetStateinstead of having separate_wasClosedinResultSetImplclose()call to superclassTasks 📍