Skip to content

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Aug 30, 2025

Rationale

Text extracted from a couple of our test files shows small whitespace differences as of a recent Tika version (not sure which one); adjust test expectations accordingly. Also, run the test with strict=true going forward, so it fails when these expectations aren't met, which was the intent. The false setting is helpful when adjusting a large number of discrepancies, but not what we want on an on-going basis.

@labkey-adam labkey-adam requested a review from a team August 30, 2025 23:09
@labkey-adam labkey-adam self-assigned this Aug 30, 2025
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried running this with the Tika update, but take your word that it will pass.

@labkey-adam labkey-adam changed the title Adjust TikaTestCase expectations for Tika 3.2.2 Adjust TikaTestCase expectations for recent Tika versions Aug 31, 2025
@labkey-adam
Copy link
Contributor Author

I haven't tried running this with the Tika update, but take your word that it will pass.

FYI: I noticed these discrepancies while testing 3.2.2, but turns out they aren't new. They show up on develop (3.2.1), but don't fail there because strict=false. So, this can be merged to develop prior to the merge forward.

@labkey-jeckels
Copy link
Contributor

Sure en

I haven't tried running this with the Tika update, but take your word that it will pass.

FYI: I noticed these discrepancies while testing 3.2.2, but turns out they aren't new. They show up on develop (3.2.1), but don't fail there because strict=false. So, this can be merged to develop prior to the merge forward.

Sure enough. https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_Bvt/3646866?buildTab=tests&name=Tika&expandedTest=build%3A%28id%3A3646865%29%2Cid%3A2000000046

@labkey-adam labkey-adam merged commit e4b9745 into develop Sep 1, 2025
10 checks passed
@labkey-adam labkey-adam deleted the fb_tika_updates branch September 1, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants