Skip to content

Update to ChargeRate.js and active view xml to have end time at the … #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonesgaohsu merged 1 commit into from
Jan 12, 2026
Merged

Update to ChargeRate.js and active view xml to have end time at the … #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion onprc_billing/resources/queries/onprc_billing/chargeRates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,18 @@ function beforeUpdate(row, errors){

function beforeUpsert(row, errors){
if (row.startDate){
// normalize to date-only (00:00)
row.startDate = ldkUtils.removeTimeFromDate(row.startDate);
}

if (row.endDate){
row.endDate = ldkUtils.removeTimeFromDate(row.endDate);
// normalize to date-only first
var cleanDate = ldkUtils.removeTimeFromDate(row.endDate);

// create a new date object set to 23:59
var endOfDay = new Date(cleanDate);
endOfDay.setHours(23, 59, 0, 0);

row.endDate = endOfDay;
}
}
2 changes: 1 addition & 1 deletion onprc_billing/resources/queries/onprc_billing/chargeRates/Active Rates.qview.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
<sort column="startDate" descending="true"/>
</sorts>
<filters>
<filter column="enddateCoalesced" operator="dategte" value="-0d"/>
<filter column="enddateCoalesced" operator="dategte" value="-0d"/> <!--changed to overwright is Active-->
</filters>
</customView>