Issue 53067: remove unnecessary output declarations that interfere with caching #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…declare outputs as they duplicate the wrapped tasks causing caching to be disabled
… configuration cache
labkey-tchad
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 53067 At some point, Gradle started to not like it when tasks shared output directories and it will not cache the task output when this happens, resulting in much more running of tasks than is strictly necessary. The wrapper tasks
npmRunBuildandnpmRunBuildProdare really more for convenience than anything, and do not need to declare explicit inputs or outputs since the output is produced by the wrapped tasks that come from the NPM plugin.Related Pull Requests
Changes