-
Notifications
You must be signed in to change notification settings - Fork 3
Support testing with serverContext on TeamCity #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This run on TeamCity was successful in setting the serverContext (default value: /) to /labkey Update: managed to figure it out- this run successfully uncomments and sets the contextpath value in the server application.properties: https://teamcity.labkey.org/buildConfiguration/bt7/3480884?buildTab=overview It appears that several tests in |
labkey-susanh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README.md file with a note about what has changed here. You can update the release version to 6.2.0 and the release date to the day you merge your change.
build.gradle
Outdated
|
|
||
| group = 'org.labkey.build' | ||
| project.version = "6.2.0-SNAPSHOT" | ||
| project.version = "6.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version should be chaged to 6.3.0-SNAPSHOT before merging.
I'm not sure that this should have ever been set to a non-snapshot version in the branch. I usually merge it with the next snapshot version then @labkey-susanh publishes the release version (not sure exactly what that process is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the process. Once this gradlePlugins branch is merged (using the next snapshot version), I'll publish the 6.2.0 version and you can update your server branch to use that version and merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, version here is now 6.3.0-SNAPSHOT
...wait. Did you mean I should make a new snapshot branch based on this FB with that version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this branch is fine. This changing of the project.version property to 6.3.0-SNAPSHOT is just in preparation for merging to develop. When publishing the plugin, I'll make a separate branch that populates this with the release version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
more succinct change summary Co-authored-by: Trey Chadick <tchad@labkey.com>

Rationale
This change updates the gradle plugin to accept system.labkey.contextPath values (via command line or set as TC property) and write the specified value to application.settings at the context.contextPath key.
This work is part of this story https://github.com/LabKey/kanban/issues/664 , the requirement is that we be able to test on TC with the server's contextPath setting set.
Related Pull Requests
(related server pr) LabKey/server#1050
Changes
pass contextPath value through