Removed unused variables, improve test credential handling, refresh blob metadata on OutputStream close

Author: labkey-jeckels

lincs/src/org/labkey/lincs/psp/LincsPspPipelineJob.java

@@ -12,7 +12,6 @@
 import org.labkey.api.util.FileUtil;
 import org.labkey.api.util.URLHelper;
 import org.labkey.api.view.ViewBackgroundInfo;
-import org.labkey.lincs.LincsModule;
 
 public class LincsPspPipelineJob extends PipelineJob implements LincsPspJobSupport
 {
@@ -43,7 +42,7 @@ public LincsPspPipelineJob(ViewBackgroundInfo info, PipeRoot root, ITargetedMSRu
 
         String baseLogFileName = FileUtil.makeFileNameWithTimestamp("LincsPSP_" + (_oldPspJob != null ? "rerun_" : "") + run.getBaseName().replace(" ", "_"));
 
-        LocalDirectory localDirectory = LocalDirectory.create(root, LincsModule.NAME, baseLogFileName,
+        LocalDirectory localDirectory = LocalDirectory.create(root, baseLogFileName,
                 !root.isCloudRoot() ? root.getRootPath().getAbsolutePath() : FileUtil.getTempDirectory().getPath());
         setLocalDirectory(localDirectory);
         setLogFile(localDirectory.determineLogFile());

panoramapublic/src/org/labkey/panoramapublic/PanoramaPublicController.java

@@ -4712,7 +4712,7 @@ private static File getLocalFile(Container container, String fileName) throws Px
                 PipeRoot root = PipelineService.get().getPipelineRootSetting(container);
                 if (root != null)
                 {
-                    LocalDirectory localDirectory = LocalDirectory.create(root, PanoramaPublicModule.NAME);
+                    LocalDirectory localDirectory = LocalDirectory.create(root);
                     return new File(localDirectory.getLocalDirectoryFile(), fileName);
                 }
                 else

panoramapublic/src/org/labkey/panoramapublic/pipeline/CopyExperimentPipelineJob.java

@@ -30,7 +30,6 @@
 import org.labkey.api.view.ActionURL;
 import org.labkey.api.view.NotFoundException;
 import org.labkey.api.view.ViewBackgroundInfo;
-import org.labkey.panoramapublic.PanoramaPublicModule;
 import org.labkey.panoramapublic.model.ExperimentAnnotations;
 import org.labkey.panoramapublic.model.Journal;
 import org.labkey.vfs.FileLike;
@@ -93,7 +92,7 @@ public CopyExperimentPipelineJob(ViewBackgroundInfo info, PipeRoot root, Experim
 
         // CONSIDER: Add a static factory method to LocalDirectory instead of using the constructor.
         //           create(@NotNull PipeRoot root, @NotNull String moduleName, @NotNull String baseLogFileName, @NotNull String localDirPath, boolean temporary)
-        LocalDirectory localDirectory = new LocalDirectory(targetRoot.getContainer(), PanoramaPublicModule.NAME, root, baseLogFileName);
+        LocalDirectory localDirectory = new LocalDirectory(targetRoot.getContainer(), root, baseLogFileName);
 
         setLocalDirectory(localDirectory);
         setLogFile(localDirectory.determineLogFile());