Skip to content

Commit 9376e82

Browse files
More FileLike
1 parent 2d2ea7d commit 9376e82

File tree

6 files changed

+28
-29
lines changed

6 files changed

+28
-29
lines changed

panoramapublic/src/org/labkey/panoramapublic/PanoramaPublicController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,8 @@
215215
import org.labkey.panoramapublic.view.expannotations.TargetedMSExperimentWebPart;
216216
import org.labkey.panoramapublic.view.expannotations.TargetedMSExperimentsWebPart;
217217
import org.labkey.panoramapublic.view.publish.CatalogEntryWebPart;
218+
import org.labkey.vfs.FileLike;
219+
import org.labkey.vfs.FileSystemLike;
218220
import org.springframework.validation.BindException;
219221
import org.springframework.validation.Errors;
220222
import org.springframework.web.servlet.ModelAndView;
@@ -1748,15 +1750,15 @@ private boolean validateAction(CopyExperimentForm form, BindException errors)
17481750
return true;
17491751
}
17501752

1751-
private Path getExportFilesDir(Container c)
1753+
private FileLike getExportFilesDir(Container c)
17521754
{
17531755
FileContentService fcs = FileContentService.get();
17541756
if(fcs != null)
17551757
{
17561758
Path fileRoot = fcs.getFileRootPath(c, FileContentService.ContentType.files);
17571759
if (fileRoot != null)
17581760
{
1759-
return fileRoot.resolve(PipelineService.EXPORT_DIR);
1761+
return FileSystemLike.wrapFile(fileRoot.resolve(PipelineService.EXPORT_DIR));
17601762
}
17611763
}
17621764
return null;

panoramapublic/src/org/labkey/panoramapublic/pipeline/CopyExperimentFinalTask.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
import org.labkey.panoramapublic.query.JournalManager;
8080
import org.labkey.panoramapublic.query.SubmissionManager;
8181
import org.labkey.panoramapublic.security.PanoramaPublicSubmitterRole;
82+
import org.labkey.vfs.FileLike;
8283

8384
import java.io.File;
8485
import java.io.IOException;
@@ -254,9 +255,9 @@ private void verifySymlinks(Container source, Container target, boolean matching
254255
}
255256
}
256257

257-
private void cleanupExportDirectory(User user, File directory)
258+
private void cleanupExportDirectory(User user, FileLike directory)
258259
{
259-
List<? extends ExpData> datas = ExperimentService.get().getExpDatasUnderPath(directory.toPath(), null, true);
260+
List<? extends ExpData> datas = ExperimentService.get().getExpDatasUnderPath(directory.toNioPathForRead(), null, true);
260261
for (ExpData data : datas)
261262
{
262263
data.delete(user);

panoramapublic/src/org/labkey/panoramapublic/pipeline/CopyExperimentJobSupport.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717

1818
import org.labkey.panoramapublic.model.ExperimentAnnotations;
1919
import org.labkey.panoramapublic.model.Journal;
20-
21-
import java.io.File;
22-
import java.nio.file.Path;
20+
import org.labkey.vfs.FileLike;
2321

2422
/**
2523
* User: vsharma
@@ -32,7 +30,7 @@ public interface CopyExperimentJobSupport
3230

3331
Journal getJournal();
3432

35-
File getExportDir();
33+
FileLike getExportDir();
3634

3735
String getReviewerEmailPrefix();
3836

@@ -48,5 +46,5 @@ public interface CopyExperimentJobSupport
4846

4947
String getPreviousVersionName();
5048

51-
void setExportTargetPath(Path exportTargetPath);
49+
void setExportTargetPath(FileLike exportTargetPath);
5250
}

panoramapublic/src/org/labkey/panoramapublic/pipeline/CopyExperimentPipelineJob.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@
3333
import org.labkey.panoramapublic.PanoramaPublicModule;
3434
import org.labkey.panoramapublic.model.ExperimentAnnotations;
3535
import org.labkey.panoramapublic.model.Journal;
36+
import org.labkey.vfs.FileLike;
3637

3738
import java.io.File;
3839
import java.io.IOException;
39-
import java.nio.file.Path;
4040

4141
/**
4242
* User: vsharma
@@ -63,7 +63,7 @@ public class CopyExperimentPipelineJob extends PipelineJob implements CopyExperi
6363

6464
private String _previousVersionName;
6565

66-
private Path _exportTargetPath;
66+
private FileLike _exportTargetPath;
6767

6868
private Container _exportSourceContainer;
6969

@@ -160,9 +160,9 @@ public Journal getJournal()
160160
}
161161

162162
@Override
163-
public File getExportDir()
163+
public FileLike getExportDir()
164164
{
165-
return _exportTargetPath.toFile();
165+
return _exportTargetPath;
166166
}
167167

168168
@Override
@@ -254,7 +254,7 @@ public void setPreviousVersionName(String previousVersionName)
254254
}
255255

256256
@Override
257-
public void setExportTargetPath(Path exportTargetPath)
257+
public void setExportTargetPath(FileLike exportTargetPath)
258258
{
259259
_exportTargetPath = exportTargetPath;
260260
}

panoramapublic/src/org/labkey/panoramapublic/pipeline/ExperimentExportTask.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
package org.labkey.panoramapublic.pipeline;
1717

1818
import org.apache.logging.log4j.LogManager;
19-
import org.apache.logging.log4j.Logger;
2019
import org.jetbrains.annotations.NotNull;
2120
import org.labkey.api.admin.FolderArchiveDataTypes;
2221
import org.labkey.api.admin.FolderExportContext;
@@ -36,8 +35,8 @@
3635
import org.labkey.api.util.PageFlowUtil;
3736
import org.labkey.api.writer.FileSystemFile;
3837
import org.labkey.panoramapublic.model.ExperimentAnnotations;
38+
import org.labkey.vfs.FileLike;
3939

40-
import java.io.File;
4140
import java.util.Collections;
4241
import java.util.List;
4342
import java.util.Set;
@@ -49,8 +48,6 @@
4948
*/
5049
public class ExperimentExportTask extends PipelineJob.Task<ExperimentExportTask.Factory>
5150
{
52-
private static final Logger _log = LogManager.getLogger(ExperimentExportTask.class);
53-
5451
private ExperimentExportTask(Factory factory, PipelineJob job)
5552
{
5653
super(factory, job);
@@ -117,15 +114,15 @@ public void writeExperiment(CopyExperimentJobSupport support, ExperimentAnnotati
117114
false, false, new StaticLoggerGetter(LogManager.getLogger(FolderWriterImpl.class)));
118115

119116

120-
File exportDir = support.getExportDir();
117+
FileLike exportDir = support.getExportDir();
121118
FileUtil.deleteDir(exportDir);
122119
if(exportDir.exists())
123120
{
124-
throw new Exception("Could not delete already existing export directory " + exportDir.getAbsolutePath());
121+
throw new Exception("Could not delete already existing export directory " + exportDir);
125122
}
126-
if(!exportDir.mkdir())
123+
if(!FileUtil.mkdir(exportDir))
127124
{
128-
throw new Exception("Could not create directory " + exportDir.getAbsolutePath());
125+
throw new Exception("Could not create directory " + exportDir);
129126
}
130127

131128
FileSystemFile vf = new FileSystemFile(exportDir);
@@ -143,7 +140,7 @@ public Factory()
143140
}
144141

145142
@Override
146-
public PipelineJob.Task createTask(PipelineJob job)
143+
public ExperimentExportTask createTask(PipelineJob job)
147144
{
148145
return new ExperimentExportTask(this, job);
149146
}

panoramapublic/src/org/labkey/panoramapublic/pipeline/ExperimentImportTask.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.labkey.api.util.FileType;
3030
import org.labkey.api.writer.FileSystemFile;
3131
import org.labkey.api.writer.VirtualFile;
32+
import org.labkey.vfs.FileLike;
3233

3334
import java.io.File;
3435
import java.util.Collections;
@@ -74,23 +75,23 @@ public RecordedActionSet run() throws PipelineJobException
7475

7576
public static void doImport(PipelineJob job, CopyExperimentJobSupport jobSupport) throws Exception
7677
{
77-
File importDir = jobSupport.getExportDir();
78+
FileLike importDir = jobSupport.getExportDir();
7879

7980
if (!importDir.exists())
8081
{
8182
throw new Exception("TargetedMS experiment import failed: Could not find directory \"" + importDir.getName() + "\"");
8283
}
8384

84-
File folderXml = new File(importDir, "folder.xml");
85+
FileLike folderXml = importDir.resolveChild("folder.xml");
8586
if(!folderXml.exists())
8687
{
87-
throw new Exception("This directory doesn't contain an appropriate xml: " + importDir.getAbsolutePath());
88+
throw new Exception("This directory doesn't contain an appropriate xml: " + importDir);
8889
}
8990

9091
User user = job.getUser();
9192
Container container = job.getContainer();
92-
VirtualFile importJobRoot = new FileSystemFile(folderXml.getParentFile());
93-
FolderImportContext importCtx = new FolderImportContext(user, container, folderXml.toPath(),
93+
VirtualFile importJobRoot = new FileSystemFile(folderXml.getParent());
94+
FolderImportContext importCtx = new FolderImportContext(user, container, folderXml,
9495
null, new PipelineJobLoggerGetter(job),
9596
importJobRoot);
9697
importCtx.setSkipQueryValidation(true);
@@ -110,7 +111,7 @@ public Factory()
110111
}
111112

112113
@Override
113-
public PipelineJob.Task createTask(PipelineJob job)
114+
public ExperimentImportTask createTask(PipelineJob job)
114115
{
115116
return new ExperimentImportTask(this, job);
116117
}

0 commit comments

Comments
 (0)