Ship the AutoFill extension and time-sensitive entitlement - #177
Merged
Conversation
…ment The developer-portal work is done, so the two entitlements and the Lab86MailAutoFill target come back on. Provisioning needed more than the app's own App ID. The extension was falling back to the wildcard "iOS Team Provisioning Profile: *", which cannot carry an app group, because no App ID existed for its bundle identifier. Created io.lab86.mail.autofill and io.lab86.mail.dev.autofill through the App Store Connect API with the App Groups capability; assigning the group itself stayed manual, as it was for the app. Verified on the Mac build box rather than assumed: the build signs, and the embedded Lab86MailAutoFill.appex carries com.apple.security.application-groups with group.io.lab86.mail and declares ProvidesOneTimeCodes. That is the first time this target has been compiled and signed at all. Note that the bundleIdCapabilities GET returns "(none)" for these App IDs even when the capabilities are demonstrably present, so it is not a usable check — a signing build is.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe iOS configuration activates time-sensitive notifications and the shared app group, enables the ChangesiOS AutoFill integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portal work is done, so both entitlements and the Lab86MailAutoFill target are back on.
The extension needed its own App IDs — it was falling back to the wildcard profile, which cannot carry an app group. Created
io.lab86.mail.autofillandio.lab86.mail.dev.autofillvia the ASC API.Verified on the Mac build box: the build signs, and the embedded appex carries
group.io.lab86.mailand declaresProvidesOneTimeCodes. First successful compile and sign of this target.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit