Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update physical constants CODATA 2022 #1196

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Update physical constants CODATA 2022 #1196

merged 5 commits into from
Sep 3, 2024

Conversation

pennalima
Copy link
Contributor

Update physical constants and derived ones according to CODATA 2022 and IAU 2015:

Newton's gravitational constant (G)
Solar mass (compatible with G)
Rho critical (compatible with G and solar mass)
Boltzmann constant
Stefan-Boltzmann constant
Planck's constant
Electron volt

Pages: CODATA 2022 https://physics.nist.gov/cuu/Constants/index.html (for example, see All values (ascii))
IAU 2015 resolutions: https://www.iau.org/static/resolutions/IAU2015_English.pdf

…nd IAU 2015:

Newton's gravitational constant (G)
Solar mass (compatible with G)
Rho critical (compatible with G and solar mass)
Boltzmann constant
Stefan-Boltzmann constant
Planck's constant
Electron volt

Pages: CODATA 2022 https://physics.nist.gov/cuu/Constants/index.html
IAU 2015 resolutions: https://www.iau.org/static/resolutions/IAU2015_English.pdf
@pennalima
Copy link
Contributor Author

Hi @damonge and @nikosarcevic,

I updated some physical constants according to CODATA 2022. But some benchmarks are failing now.
We need to generate the following files again: pt_bm_lpt_z0.txt and pt_bm_lpt_z1.txt. They are called in benchmarks/test_ptpk_lpt.py.
Do you know who (or how) to generate these files?

@nikosarcevic
Copy link
Contributor

Hi @damonge and @nikosarcevic,

I updated some physical constants according to CODATA 2022. But some benchmarks are failing now. We need to generate the following files again: pt_bm_lpt_z0.txt and pt_bm_lpt_z1.txt. They are called in benchmarks/test_ptpk_lpt.py. Do you know who (or how) to generate these files?

Hi, Marianna,

I was busy last week with the viva and I want to finish something before Thursday. Maybe if you can show up in the forecasting telecon this week and we can go over it?

Also, @damonge -- when will we have the ccl telecon? would be good to start it now that September is here.

@pennalima
Copy link
Contributor Author

Hi @nikosarcevic ,

Talk to you on Thursday.

@damonge
Copy link
Collaborator

damonge commented Sep 3, 2024

I think this is due to an update in velocileptors, and has nothing to do with the constants update. I've updated the benchmarks. Let's see if that does it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10681050888

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.464%

Totals Coverage Status
Change from base Build 9990842930: 0.0%
Covered Lines: 6611
Relevant Lines: 6783

💛 - Coveralls

@damonge
Copy link
Collaborator

damonge commented Sep 3, 2024

@pennalima this seems to have worked. Is this ready for a review?

@pennalima
Copy link
Contributor Author

Hi @damonge,

Thanks a lot for checking it.
Yes, it is ready for review.

Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damonge
Copy link
Collaborator

damonge commented Sep 3, 2024

Great, done! Feel free to merge.

@pennalima pennalima merged commit a14a717 into master Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants