-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update physical constants CODATA 2022 #1196
Conversation
…nd IAU 2015: Newton's gravitational constant (G) Solar mass (compatible with G) Rho critical (compatible with G and solar mass) Boltzmann constant Stefan-Boltzmann constant Planck's constant Electron volt Pages: CODATA 2022 https://physics.nist.gov/cuu/Constants/index.html IAU 2015 resolutions: https://www.iau.org/static/resolutions/IAU2015_English.pdf
Hi @damonge and @nikosarcevic, I updated some physical constants according to CODATA 2022. But some benchmarks are failing now. |
Hi, Marianna, I was busy last week with the viva and I want to finish something before Thursday. Maybe if you can show up in the forecasting telecon this week and we can go over it? Also, @damonge -- when will we have the ccl telecon? would be good to start it now that September is here. |
Hi @nikosarcevic , Talk to you on Thursday. |
I think this is due to an update in velocileptors, and has nothing to do with the constants update. I've updated the benchmarks. Let's see if that does it. |
Pull Request Test Coverage Report for Build 10681050888Details
💛 - Coveralls |
@pennalima this seems to have worked. Is this ready for a review? |
Hi @damonge, Thanks a lot for checking it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Great, done! Feel free to merge. |
Update physical constants and derived ones according to CODATA 2022 and IAU 2015:
Newton's gravitational constant (G)
Solar mass (compatible with G)
Rho critical (compatible with G and solar mass)
Boltzmann constant
Stefan-Boltzmann constant
Planck's constant
Electron volt
Pages: CODATA 2022 https://physics.nist.gov/cuu/Constants/index.html (for example, see All values (ascii))
IAU 2015 resolutions: https://www.iau.org/static/resolutions/IAU2015_English.pdf