Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Calculations #1148

Closed
wants to merge 127 commits into from
Closed

Background Calculations #1148

wants to merge 127 commits into from

Conversation

hsinfan1996
Copy link
Contributor

Merge existing distances_v3 branch to master (different from PR #1066 ). Closes issue #954 andd #408

nikfilippas and others added 24 commits April 6, 2023 22:11
* done

* Make `T_ncdm` a cosmological parameter + (v3) (#1049)

* first commit

* rename TNCDM to T_ncdm but preserve API

* T_CMB directly into cosmo struct

* Omega_g in ccl_parameters_create; no split between C/Python

* physical_constants.T_CMB doesn't mutate anymore!

* force mutate T_CMB in benchmarks

* define defaults on instantiation just in case constants mutate

* A_s & sigma8: don't play with numbers

* simplify

* remove leftover mallocs

* temporarily preserve API for CCLv3

* Unfreeze option for `physical_constants` (#1050)

* first commit

* update rtd

* addressed comments 1

* Remove `T_CMB` and `T_ncdm` as constants (reloaded) (#1058)

* first commit

* OmNuh2 fix

* addressed comments

* keep only massive

* first step

* temp commit

* debug neutrinos & deprecate Omnuh2

* ccl_omega_x & ccl_Omeganuh2 consistency

---------

Co-authored-by: David Alonso <[email protected]>

* RTD: Removed The Docs

---------

Co-authored-by: David Alonso <[email protected]>

* flaked

---------

Co-authored-by: Nick Koukoufilippas <[email protected]>
@nikosarcevic
Copy link
Contributor

I will check it today, sorry I was very busy yesterday. thanks for this, much obliged!

@hsinfan1996
Copy link
Contributor Author

I will check it today, sorry I was very busy yesterday. thanks for this, much obliged!

No worries. Take your time. And the correct PR is #1149 . This one is closed because I don't want to modify the original distances_v3 branch.

@nikosarcevic
Copy link
Contributor

I will check it today, sorry I was very busy yesterday. thanks for this, much obliged!

No worries. Take your time. And the correct PR is #1149 . This one is closed because I don't want to modify the original distances_v3 branch.

got it! many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants