Add Thunder API Consumer Contract Guide for Silver#316
Merged
maneeshaxyz merged 2 commits intoLSFLK:mainfrom Mar 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation file, 'Thunder-API-Consumer-Contract-Guide-for-Silver.md', which outlines the API consumer contract between the Silver and Thunder teams. The review identified several inaccuracies and inconsistencies that need to be addressed: the documentation references a sample script and application that are not currently implemented, the 'id' field for admin user creation should be marked as required rather than recommended to ensure bootstrap success, and the section numbering in the endpoint contracts does not align with the summary table.
Aravinda-HWK
added a commit
to Aravinda-HWK/silver
that referenced
this pull request
Mar 31, 2026
* Add Thunder API Consumer Contract Guide for Silver * Remove outdated Thunder integration documentation from Silver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Create Thunder API consumer contract guide for silver document.
🔍 Changes Made
✅ Checklist (Email System)
🧪 Testing Instructions
📷 Screenshots / Logs (if applicable)