290 task remove scripts that do ipd functionality#293
Conversation
…ithub.com:maneeshaxyz/silver into 290-task-remove-scripts-that-do-ipd-functionality
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request simplifies the Silver Mail system's initial setup by decoupling user management functionality from the core mail service deployment. It removes a dedicated script for adding users and integrates with an Identity Provider (IDP), and streamlines the main setup script by eliminating a step related to IDP user schema initialization. This change focuses on making the mail system setup more concise and potentially shifts IDP-related user provisioning to a separate, external process. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes functionality related to user management from setup scripts. Specifically, it removes the add_user.sh script entirely and the 'Initialize Thunder User Schema' step from start-silver.sh. These changes are accompanied by updates to step counters in the script's output and minor cosmetic cleanup of ASCII banners. The changes align with the goal of decoupling user management from the initial setup scripts. One suggestion is provided to improve the maintainability of the step-counting logic in start-silver.sh.
| # Step 1: Domain Configuration | ||
| # ================================ | ||
| echo -e "\n${YELLOW}Step 1/4: Configure domain name${NC}" | ||
| echo -e "\n${YELLOW}Step 1/3: Configure domain name${NC}" |
There was a problem hiding this comment.
To improve maintainability, consider defining the total number of steps in a variable at the top of the script (e.g., TOTAL_STEPS=3). This would make it easier to update if steps are added or removed in the future, as you'd only need to change one value. This change should be applied to all step announcements in this script (steps 1/3, 2/3, and 3/3).
Aravinda-HWK
deleted the
290-task-remove-scripts-that-do-ipd-functionality
branch
* chore: remove Thunder Initialisation steps. * chore: remove add_user.sh * chore: fix format issue
2 participants
📌 Description
🔍 Changes Made
add_user.shsetup.shstart-silver.sh✅ Checklist (Email System)