Fix ZynAddSubFX preset regression #7737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out why the velocities are different: The Zyn VK uses a velocity of 100 by default. However, the LMMS piano seems to use 0...63 by default. This seems to be an issue on master. Can please anyone test this PR? |
|
Testing notes: There are a variety of things to test in different combinations:
All these should be tested both without and with GUI open So there is really a LOT to test 🤣 |
Also, this PR lets old preset load with old filter cutoff, after this had been changed in 9c0fc8f . Co-authored-by: Lost Robot <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #7720 . I think this is wrong yet, because the VK in Zyn has different filter freq than the Piano in LMMS.
Please test or give feedback.
Credits to the idea of this fix go to LostRobot.