Stream sample previews instead of loading all contents into memory #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More consistent with SampleFrame, SampleBuffer, SampleClip, etc
…f_wchar_open isn't always defined
|
This works great for previewing longer samples. Sadly, something about this branch is buggy when testing with Sample Tracks. It crashes just about every time I try it. I was unable to reproduce this crash on master. stream.mov |
Odd.. how unfortunate. I'll draft this PR and take a look when I get the chance. I need to deal with this crash as well as figuring out the code overlap between the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds streaming support for sample files. This means that sample files can be streamed in instead of being loaded all at once into memory. This is especially useful for when you do not necessarily depend on all the sample data, but as they are processed. Currently, only sample previews in the
FileBrowsermake use of sample streams. This should help improve performance when previewing large sample files.