[Code Cleanup] Cleaned up some header files and move a bit of debugging logic to cmake #7677
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Rossmaxx
changed the title
lmms_basics.h and simplify the LMMS_STRINGIFY macro to be used at call sites.lmms_basics.h and scope it down to type declaration
|
Do note that the diff itself is small. Most of the thing is due to the file rename in the #include statement |
|
Now i should hunt down any unused includes over here, but I don't really have the insanity to do that manually. Edit: using iwyu, I could somewhat automate this process. |
|
I'll fix the declaration later. |
|
Seems like I got myself into a rabbit hole with this refactoring |
Rossmaxx
changed the title
lmms_basics.h and scope it down to type declaration
|
I'm done now. |
Rossmaxx
force-pushed
the
clean-lmms-basics
branch
from
dff51ab to
9e25b29
Compare
|
ahh crap, i messed up a rebase |
|
I'll fix stuff later |
Rossmaxx
force-pushed
the
clean-lmms-basics
branch
from
a339a32 to
3fb24f2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Rossmaxx
force-pushed
the
clean-lmms-basics
branch
from
72fd59d to
8cf8b36
Compare
|
I'll undraft the PR once I manage to fix the history. The work is done for now. |
When I get into a pickle like this, I take the lazy route and PR against a test branch that's even with master, squash everything down, force that commit back. For this reason, I'm probably not a good person to ask. Last time my efforts were scrutinized #7726. Perhaps someone with more experience in this area can help. |
|
I found a way to fix it. I'll reorder commits using an interactive rebase. But it is a bit effort consuming tho. |
Rossmaxx
force-pushed
the
clean-lmms-basics
branch
from
303612f to
756c90e
Compare
forgot to add my name to copyright file
nvm, release is better This is redundant as cmake already handles this logic added the correct behaviour for NDEBUG flag order change
include the cstdint header which should be it
fix build
Rossmaxx
force-pushed
the
clean-lmms-basics
branch
from
9880fd6 to
b7eb195
Compare
|
Eureka, I managed to fix everything. GPT o1 really came in clutch here. |
lmms_basics.htoLmmsTypes.hand scoped it down for that purpose.LMMS_STRINGIFYmacro to it's own header.debug.hheader file and use cmake handle the macro logic.