Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German translation #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update German translation #390

wants to merge 1 commit into from

Conversation

Wuzzy2
Copy link

@Wuzzy2 Wuzzy2 commented Nov 25, 2024

The German translation of the website was quite bad, so I decided to rework it. The following changes were made:

  • Fix bad grammar, typos, figure-of-speeches
  • Translated every untranslated string except the historical competition rules
  • Fixed inconsistent use of formal vs informal language. I picked formal ("Sie") because that's what the LMMS application has been using so far

WARNING: This translation was NOT tested.

@liushuyu
Copy link
Member

Hi there, thanks for your contribution! I have uploaded your translation to our translation platform and merged the new translations there into your repository.
Can you take another look to see if the merge is correct? Thanks!

@Wuzzy2
Copy link
Author

Wuzzy2 commented Jan 29, 2025

Yes, I can take another look.

And after I looked, it seems the *.xif file looks still like the old version. I can’t seem to find a commit that updates the German translation like I did here. The last translation-updating commit I could find (5caf415) only touches 1 string, which isn’t my work.

Can you please try again and point me towards the merge commit once you’re done? Thanks. The correct merge commit should be pretty large for German (definitely not just 1 or 2 string updates), as you can see in the file diff for this PR.

@liushuyu
Copy link
Member

Yes, I can take another look.

And after I looked, it seems the *.xif file looks still like the old version. I can’t seem to find a commit that updates the German translation like I did here. The last translation-updating commit I could find (5caf415) only touches 1 string, which isn’t my work.

Can you please try again and point me towards the merge commit once you’re done? Thanks. The correct merge commit should be pretty large for German (definitely not just 1 or 2 string updates), as you can see in the file diff for this PR.

I have merged the translations based on your work, so if any translations differ, your work takes precedence over the Transifex data. So this should be normal.

@Wuzzy2
Copy link
Author

Wuzzy2 commented Jan 30, 2025

And yet the *.xlf file does not contain my updated translations. This can be easily discovered if you just do a quick string-by-string comparison of the first few strings, where you compare my new *.xlf file with the *.xlf file currently in this repo.

So far, this looks like the merge didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants