Fix Dynamic memory space when configured with Umpire #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New test uses all available memory spaces and reallocates memory between them. The test crashes because we assume memory is from Umpire even when it's Dynamic.
This fixes (1) Dynamic memory space allocation/reallocation and (2) reallocations betwen Dynamic memory space and Umpire spaces.
gunney1
added
bug
gunney1
requested review from
white238,
kennyweiss,
rhornung67,
publixsubfan,
bmhan12 and
Arlie-Capps
kennyweiss
reviewed
Mar 4, 2025
| @@ -506,3 +506,72 @@ TEST(core_memory_management, allocator_id_from_pointer) | |||
| delete[] buf; | |||
| } | |||
| #endif | |||
|
|
|||
| //------------------------------------------------------------------------------ | |||
| TEST(core_memory_management, interspace_reallocation) | |||
kennyweiss
requested changes
Mar 5, 2025
There was a problem hiding this comment.
@gunney1 and I discussed this today, and he will rework this PR.
It seems that he has a user request to support malloc allocations through Axom's memory_management API even when Axom is configured with Umpire.
I recommended that this new use case should use an allocator ID that is not valid with umpire (e.g. a negative number other than -1, which we currently use as our INVALID_ALLOCATOR_ID).
He will also remove/rename the DYNAMIC_ALLOCATOR_ID global variable, which was only recently added since the name is confusing and it uses a potentially valid Umpire allocator ID (0)
meaning. I had confused dynamic with malloc. There was no allocator specifically for malloc/free. Now there is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main fixes check whether a pointer is from Umpire or an allocator id indicates Umpire. If the pointer is not Umpire, assume it's in the Dynamic memory space and deallcoate or reallocate accordingly. Without handling this in Axom, Umpire throws an exception when it tries to handle the external pointer.