Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sina/hdf5 output support #1480
base: develop
Are you sure you want to change the base?
Feature/sina/hdf5 output support #1480
Changes from 6 commits
3f09c5e
e0cd5bf
d2f38ac
6c32398
31242a6
aa9073d
b553c44
c5c0cb4
8dd8a84
8e6afc1
247591f
703dbd1
e1d7631
0df65b3
e118d24
0f5851e
1168000
429d9ce
b71b05d
0b689db
ccfa513
c05979d
7c5d7cc
d036b67
79f3729
f92080d
4310ee1
0fd3a35
1145c29
4043d3e
3ccfbb3
9429b60
45ee75b
0f016bb
4a2cf7e
2499896
209ee7d
35bf45b
64e5026
a0341da
baf2492
3e03355
8370a21
50f17e1
6160d87
fb3554d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a ref to avoid a copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as many copies as I could, this one underwent additional changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could pass ref to append result into removeSlashes to avoid one extra copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the changes pushed? I see:
however, I expect something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyrush @gwaegner cannot push. I just pushed the changes.