Fix shape in View::deepCopyView
#1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunney1
added
bug
gunney1
commented
Jul 24, 2024
agcapps
approved these changes
Aug 2, 2024
kennyweiss
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks for the fix @gunney1
Would it be possible to add a regression test for this? e.g. a case that failed w/ the old way that passes w/ this fix.
This change removes the need for fixing the shape after allocating.
gunney1
force-pushed
the
bugfix/gunney/deep-copy-view
branch
from
6240fe6 to
ed269dd
Compare
Regression test added. |
nselliott
reviewed
Aug 9, 2024
gunney1
force-pushed
the
bugfix/gunney/deep-copy-view
branch
from
7308381 to
d1e34f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep-copying a view fails to set the destination shape to the source's.
This bug fix follows the data allocation with a call to correctly set the destination shape.
It also fixes comments and prefixes some variable names with "src" or "dst" to clarify their role in the copy.