If shape pointer is null, warn and don't allocate.

Author: gunney1

src/axom/sidre/core/View.cpp

@@ -133,20 +133,27 @@ View* View::allocate(TypeID type, int ndims, const IndexType* shape, int allocID
                  SIDRE_VIEW_LOG_PREPEND
                    << "Could not allocate: Data type was 'NO_TYPE_ID'.");
 
+  SLIC_CHECK_MSG(shape != nullptr,
+                 SIDRE_VIEW_LOG_PREPEND
+                   << "Could not allocate: specified shape is nullptr.");
+
   IndexType num_elems = 1;
-  for(int d = 0; d < ndims; ++d)
+  if(shape != nullptr)
   {
-    SLIC_CHECK_MSG(
-      shape[d] > 0,
-      SIDRE_VIEW_LOG_PREPEND << "Could not allocate: shape is non-positive.");
-    num_elems *= shape[d];
-    if(num_elems <= 0)
+    for(int d = 0; d < ndims; ++d)
     {
-      break;
+      SLIC_CHECK_MSG(
+        shape[d] > 0,
+        SIDRE_VIEW_LOG_PREPEND << "Could not allocate: shape is non-positive.");
+      num_elems *= shape[d];
+      if(num_elems <= 0)
+      {
+        break;
+      }
     }
   }
 
-  if(ndims > 0 && num_elems > 0 && type != NO_TYPE_ID)
+  if(ndims > 0 && shape != nullptr && num_elems > 0 && type != NO_TYPE_ID)
   {
     describe(type, ndims, shape);
     allocate(allocID);

src/axom/sidre/core/View.hpp

@@ -372,8 +372,8 @@ class View
    *
    * \note The allocate() method (above) describes conditions where View
    *       allocation is allowed.  If the conditions are not met,
-   *       type is NO_TYPE_ID, or ndims < 0, or any element of shape < 0,
-   *       this method does nothing.
+   *       type is NO_TYPE_ID, or ndims < 0, or shape is nullptr,
+   *       or any element of shape < 0, this method does nothing.
    *
    * \return pointer to this View object.
    */