fix(auth): allow overriding siwe message fields #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the WalletClientAuthenticator.authenticate method to allow overriding specific SIWE (Sign-In with Ethereum) message fields while keeping nonce generation internal. The enhancement provides more flexibility for customizing authentication messages without exposing sensitive nonce generation logic.
- Added a new optional third parameter for SIWE message field overrides
- Introduced type safety with
WalletClientAuthenticateOverridestype - Restructured the message building logic to merge overrides with default parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Ansonhkg
requested review from
DashKash54,
FedericoAmura,
MaximusHaximus,
awisniew207,
Copilot,
glitch003 and
spacesailor24
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
WalletClientAuthenticator.authenticateto accept partial SIWE overrides via an optional third argument. This keeps nonce generation internal while merging provided SIWE fields before signingpatchchangesetThis should fix the following error:
