-
Notifications
You must be signed in to change notification settings - Fork 86
chore: sync constants version with lit-client #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ansonhkg
wants to merge
4
commits into
naga
Choose a base branch
from
feat/version-sync
base: naga
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export const version = '8.0.0-alpha.4'; | ||
// This value is kept in sync with @lit-protocol/lit-client via scripts/sync-version.mjs, run by the build command. | ||
export const version = '8.0.0'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
#!/usr/bin/env node | ||
|
||
import { readFile, writeFile } from 'node:fs/promises'; | ||
import { dirname, resolve } from 'node:path'; | ||
import { fileURLToPath } from 'node:url'; | ||
|
||
// Anchor paths relative to repo root so the script works from any cwd. | ||
const __filename = fileURLToPath(import.meta.url); | ||
const __dirname = dirname(__filename); | ||
const repoRoot = resolve(__dirname, '..'); | ||
|
||
// Matches the exported version constant in packages/constants/src/lib/version.ts. | ||
const VERSION_EXPORT_PATTERN = /export const version = ['"]([^'\"]+)['"];?/; | ||
|
||
async function main() { | ||
const litClientPackageJsonPath = resolve( | ||
repoRoot, | ||
'packages', | ||
'lit-client', | ||
'package.json' | ||
); | ||
const versionFilePath = resolve( | ||
repoRoot, | ||
'packages', | ||
'constants', | ||
'src', | ||
'lib', | ||
'version.ts' | ||
); | ||
|
||
let litClientPackageJson; | ||
try { | ||
litClientPackageJson = JSON.parse( | ||
await readFile(litClientPackageJsonPath, 'utf8') | ||
); | ||
} catch (err) { | ||
throw new Error( | ||
`Failed to read or parse package.json at ${litClientPackageJsonPath}: ${err.message}` | ||
); | ||
} | ||
const litClientVersion = litClientPackageJson.version; | ||
|
||
if (!litClientVersion) { | ||
throw new Error(`Version not found in ${litClientPackageJsonPath}`); | ||
} | ||
|
||
let versionFileContents; | ||
try { | ||
versionFileContents = await readFile(versionFilePath, 'utf8'); | ||
} catch (err) { | ||
throw new Error( | ||
`Failed to read version file at ${versionFilePath}: ${err.message}` | ||
); | ||
} | ||
const match = versionFileContents.match(VERSION_EXPORT_PATTERN); | ||
|
||
if (!match) { | ||
throw new Error( | ||
`Could not find exported version constant in ${versionFilePath}` | ||
); | ||
} | ||
|
||
const currentVersion = match[1]; | ||
|
||
if (currentVersion === litClientVersion) { | ||
console.log(`version.ts already in sync (${currentVersion})`); | ||
return; | ||
} | ||
|
||
// Rewrite the version export so it mirrors the lit-client package version. | ||
const updatedContents = versionFileContents.replace( | ||
VERSION_EXPORT_PATTERN, | ||
`export const version = '${litClientVersion}';` | ||
); | ||
|
||
await writeFile(versionFilePath, updatedContents); | ||
console.log(`Updated version.ts to ${litClientVersion}`); | ||
} | ||
|
||
main().catch((error) => { | ||
console.error(error); | ||
process.exitCode = 1; | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex character class
[^'\"]+
contains an unescaped double quote inside the brackets, which could cause parsing issues. The double quote should be escaped:[^'\\\"]+
Copilot uses AI. Check for mistakes.