-
Notifications
You must be signed in to change notification settings - Fork 87
⭐️ [Refactor] [bun > pnpm] Feature/jss 93 refactor bun pnpm #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
🦋 [Main] Naga Branch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typedoc-theme-hierarchy because it blocked upgrades, and moved typedoc to 0.28.12 for compatibility with TypeScript 5.8+.
… minimal module mapping, dotenvx for envs - Switched Bun TS runner to Node + tsx with dotenvx wrapping for env loading. - Replaced Bun E2E runner with Jest using a dedicated jest e2e config - Resolved CJS/ESM breakages by using Babel transfomer for .ts|.js| in Jest. - Avoided duplicated module resolution: ignored `.nx/` and `dist/` in Jest. - Prevented hijacking external `@lit-protocol/*` and only map local packages
… minimal module mapping, dotenvx for envs - Switched Bun TS runner to Node + tsx with dotenvx wrapping for env loading. - Replaced Bun E2E runner with Jest using a dedicated jest e2e config - Resolved CJS/ESM breakages by using Babel transfomer for .ts|.js| in Jest. - Avoided duplicated module resolution: ignored `.nx/` and `dist/` in Jest. - Prevented hijacking external `@lit-protocol/*` and only map local packages
… only supports `babel-jest@^.29`.
…update reset script in package.json
- ESlint 8.48.0 no longer supported - @walletconnect/ethereum-provider is unused - uuidv4 to `crypto.randomUUID()` `@simplewebauthn/typescript-types` is NOT yet replaced with later types as unsure with side effects, locked-in to a particular version instead.
…sistency across all packages
…will be using the logger package instead
```ts
await client.authService.mintWithAuth({
authData,
authServiceBaseUrl,
scopes,
apiKey: 'YOUR_API_KEY',
});
```
```ts
await WebAuthnAuthenticator.registerAndMintPKP({
authServiceBaseUrl,
scopes,
apiKey: 'YOUR_API_KEY',
});
```
Upcoming PR to use .overrides authBaseUrl and API key instead.
- fixed env should be service specific - added html packages back to lit-login-server - renamed lit-*-service to lit-*-server - return express instance for devs to customise - pinned @ts-oss/env-cors version This commit has also been tested locally using the E2E test dApp
…bstract-provider' or its corresponding type declarations.
…Cannot find module '@ethersproject/contracts' or its corresponding type declarations.` error from `packages/access-control-conditions/src/lib/humanizer.ts:1:26`
…y` and update main entry point to index.ts
…rsion 21.2.1, removing deprecated settings and adjusting package versions for compatibility
…ority of them came from `createContractManager` which supplies incompatible client shapes (or mixing public/wallet inference) made Client generics collide. Explicit PublicClient annotation triggered heavy generic expansion and account mismatches. Letting TS infer the type from createPublicClient resolves this. - removed capacity credits as we have remove this concept for Naga - Using `LitResourceAbilityRequestSchema` inferred type instead of legacy `CapacityDelegationRequest` (Types to be removed) - Login server Node's CJS resolving dir name - types on JobStatus - declare the `auth-services` package as types node - replaced @ts-expect-error in error.ts to @ts-ignore - fixed the type from Ajv - Introduced StrictAuthData instead of inline type - bindAccount helper in the createChainManagerFactory to fix signature mismatch - updated targets from ES2020 to ES2022
…xecutable via node eg. `NODE_OPTIONS=--no-deprecation node ./dist/apps/lit-login-server/main.cjs`
…ker release workflow
…rver to use multi-platform support and streamline dependency installation
…servers in README
…as CommonJS again so bundlers stop loading the build artifacts in ESM mode and hitting exports runtime errors - Point the few packages whose main/types fields were still referencing the old ./dist paths at the real build outputs instead, so consumers resolve the CJS entry on first try instead of falling through to the broken ESM path
…d 1.0.12-test.9; update changelogs
**Auth Flow Hardening** 1. (feat) DiscordAuthenticator - it now forces you to support the real Discord client id wheever you hit a non-default login server, so the hashed `authMethodId` lines up with what the Lit nodes compute 2. (fix) WebAuthnAuthenticator - Refuse "successful" jobs that returns no payload. Make the service path fail loudly instad of handing back undefined data. **Auth Service** 1. (fix) add network-scoped queue names, so multi-network deploytments stops overwriting each other's BullMQ jobs. 2. (fix) initSystemContext - dropped the silent `naga-dev` default and demand an explict `NETWORK`, preventing workers from accidentally botting against the wrong network. 3. (chore) remove unsued route **Networks * Lit Client** 1. (refactor): stop hard-coding `authServiceBaseUrl` - the SDK will rely on runtime config so staging URLs don't leak into other envs. 2. (fix): Remove Strict Auth Data and make it Partial<AuthData> 3. (chore) add tracing the `mintWithAuth`
…s and pricing - limit JIT keyset creation to nodes that actually returned server keys and filter price data to match, avoiding encryption attempts against missing nodes (packages/networks/src/networks/vNaga/shared/factories/BaseModuleFactory.ts) - adjust PKP and custom auth adapters to derive node pricing only from responding nodes and fail fast if they can’t satisfy the threshold, preventing session-sign requests from targeting unreachable URLs (packages/auth/src/lib/AuthManager/authAdapters/getPkpAuthContextAdapter.ts, getCustomAuthContextAdapter.ts)
- wire `/register-payer` and `/add-users` into the auth Express app - lazily manage Lit client lifecycle, reusing worker instance when present - derive payer wallets deterministically and delegate via PaymentManager - expose auth-service `registerPayer` / `delegateUsers` helpers in networks + client SDK
…th-services-from-elysia-to-express Feature/jss 105 refactor auth services from elysia to express
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
17.3.0and pinned to21.2.10.19.2to satisfy Nx, removedtypedoc-theme-hierarchybecause it blocked upgrades, and movedtypedocto0.28.12for compatibility with TypeScript 5.8+..envand run thegen:local-network-contextusingtsx. PreviouslyBunwould automatically detect and load the.envfile.Do not merge this until these are merged
Based off this branch (pnpm migration)
UPDATE 22/09/2025
Do not merge until load testing is done or ✅ from @hwrdtm