chore(ci): update e2e workflow to include additional branches for pul… #862
Conversation
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
requested review from
glitch003,
FedericoAmura,
MaximusHaximus,
DashKash54 and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the development workflow by adding automated code quality enforcement and expanding CI coverage. The changes add Husky for Git hooks with linting and commit message validation, while also extending E2E test triggers to include feature branches and the naga branch.
- Added Husky with pre-commit hooks for automated linting and type checking
- Configured lint-staged to run prettier and eslint on staged files, excluding generated files
- Extended E2E workflow triggers to include naga branch and feature branches
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added husky and lint-staged dependencies with prepare script |
| .lintstagedrc.js | Configured lint-staged to format and lint TypeScript/JavaScript files and JSON/Markdown files |
| .husky/pre-commit | Set up pre-commit hook to run lint-staged and typecheck |
| .husky/commit-msg | Added commit message validation for conventional commits |
| .github/workflows/e2e.yml | Extended workflow triggers to include naga and feature branches |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if ! head -1 "$1" | grep -qE "^(feat|fix|chore|docs|test|style|refactor|perf|build|ci|revert|wip)(\(.+?\))?: .{1,}$|^Merge branch .+$"; then | ||
| echo "Aborting commit. Your commit message must match https://www.conventionalcommits.org/en/v1.0.0/" >&2 | ||
| exit 1 | ||
| fi No newline at end of file |
There was a problem hiding this comment.
There is a trailing space after 'fi' which should be removed for cleaner code.
| fi | |
| fi |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
CLUTCH REVIEW FEEDBACK.
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
|
The CI is working on features branches |
WHAT
featurebranches andnagabranch to ensure E2E tests run on all dev workflows.