Pull-request para las convenciones #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloem
reviewed
Jan 23, 2025
| @@ -17,7 +17,6 @@ | |||
| "@uiw/codemirror-theme-github": "^4.21.25", | |||
| "@uiw/codemirror-theme-vscode": "^4.21.25", | |||
| "@uiw/react-codemirror": "^4.21.25", | |||
| "@vercel/analytics": "^1.2.2", | |||
There was a problem hiding this comment.
porque quitaron esto? causo problemas? mejor no quitarlo
There was a problem hiding this comment.
favor de re-agregar vercel analytics : )
This reverts commit e7aedc3.
pabloem
reviewed
Jan 23, 2025
| specialValues.includes(field.default.toLowerCase()) | ||
| /^(?:[01]?\d|2[0-3]):[0-5]?\d:[0-5]?\d([+-]\d{2}:\d{2})?$/.test( | ||
| field.default, | ||
| ) || specialValues.includes(field.default.toLowerCase()) |
There was a problem hiding this comment.
porque este cambio? es posible des-hacerlo?
| @@ -1,6 +1,5 @@ | |||
| import ReactDOM from "react-dom/client"; | |||
| import { LocaleProvider } from "@douyinfe/semi-ui"; | |||
| import { Analytics } from "@vercel/analytics/react"; | |||
There was a problem hiding this comment.
deshacer este cambio porfa (y la linea al final del archivo)
| @@ -7,6 +7,16 @@ const binaryRegex = /^[01]+$/; | |||
|
|
|||
| /* eslint-disable no-unused-vars */ | |||
| const defaultTypesBase = { | |||
| NUMBER: { | |||
There was a problem hiding this comment.
esto es por curiosidad - porque agregaron estos aqui en defaultTypeBase? son necesarios?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agregando convenciones de Oracle