Draft
Conversation
src/sparging/correlations.py
Outdated
| ) | ||
| if not arg.check(expected_dimension): | ||
| if not arg.dimensionality == ureg(expected_dimension).dimensionality: | ||
| breakpoint() |
Member
Author
There was a problem hiding this comment.
Note should remove this
src/sparging/correlations.py
Outdated
Comment on lines
+77
to
+80
| warnings.warn( | ||
| f"Correlation with identifier {identifier} not found in correlation group" | ||
| ) | ||
| return None |
Member
Author
There was a problem hiding this comment.
I think this should fail and not just raise an error
…input() and inputs.resolve_correlation())
| identifier="drho", | ||
| function=lambda rho_l, rho_g: (rho_l - rho_g).to( | ||
| "kg/m**3" | ||
| ), # density difference between liquid and gas |
Member
Author
There was a problem hiding this comment.
Suggested change
| ), # density difference between liquid and gas | |
| ), | |
| description="density difference between liquid and gas", |
| identifier="rho_g", | ||
| function=lambda temperature, P_bottom: ureg.Quantity( | ||
| (P_bottom * he_molar_mass / (const_R * temperature.to("kelvin"))).to("kg/m**3") | ||
| ), # ideal gas law for density of gas phase |
Member
Author
There was a problem hiding this comment.
Suggested change
| ), # ideal gas law for density of gas phase | |
| ), |
Member
Author
There was a problem hiding this comment.
we should maybe move this file to an example folder and add it to the CI
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| output_units: str | None = None | ||
|
|
||
| def __call__(self, **kwargs): | ||
| def __call__(self, **kwargs: pint.Quantity) -> pint.Quantity: |
Member
Author
There was a problem hiding this comment.
kwargs here is not a pint.Quantity but a Dict[str: pint.Quantity]
… input with reference result (as a consistency check) + updated test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.