Add image filter to cache #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need this. Instead, increase the cargo version from masterV2 to masterV3. The cache will won't consider files with older versions. |
|
Now get_previous_image_path returns error to the old version of cache and users will be forced to set the wallpaper again to update cache. |
LGFae
reviewed
Oct 27, 2024
common/src/cache.rs
Outdated
| let mut filepath = cache_dir()?; | ||
| clean_previous_verions(&filepath); | ||
|
|
||
| filepath.push(output_name); | ||
| if !filepath.is_file() { | ||
| return Ok("".to_string()); | ||
| return Ok(("Lanczos3".to_string(), "".to_string())); |
There was a problem hiding this comment.
I don't really get what this gives us. Is it just to improve the error messages?
There was a problem hiding this comment.
Yes, and it makes it easy to force swww-daemon ignore missing cache files.
|
How swww restore don't stop half done if one of the outputs don't have cache file and print name of the output for all errors |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I primary use pixel art wallpapers, so the default filter for all restored images was annoying.
I modified cache so it stores filter and path to image separated by '\n' (I couldn't think of anything better). It can work with old version of cache if it doesn't contain '\n' using default filter.
I also fixed a crash that occurred when using a solid color on my system (EndevourOS + Hyprland): the drawable surface required RGBA image but was only provided with RGB.
I'm still learning Rust and English is not my native language, so sorry if anything is wrong.