fix: honour already provided source files when compiling

[ivokub]

When we do:

compiler.Compile(field.KOALABEAR_16, cfg.GetMaxStaticHeight(), srcFiles...)

we can already provide all the source files. However, in the pre-PR implementation we still searched the file system for the file when looking for files to link even if it was already provided. This prevents for example embedding the arithmetization into a binary (through an archive or fs.FS implementation for example).

This PR fixes the case and makes the source file searcher to skip loading files from file system if it is already provided in a call to compiler.Compile.

[CLAassistant]

All committers have signed the CLA.

[Copilot]

Pull request overview

This PR updates the ZkC compiler’s include-scanning logic to avoid re-reading source files from the host filesystem when those files were already supplied directly to compiler.Compile(...). This aligns compilation behavior with use cases where callers preload sources (e.g., from an archive or other non-filesystem source) and want includes to resolve without additional filesystem access.

Changes:

• During include scanning, skip filesystem globbing/loading when the included path is already present in knownSourceFiles.
• Canonicalize the include pattern path before checking/deduping against knownSourceFiles, matching how top-level inputs are keyed.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[DavePearce]

This prevents for example embedding the arithmetization into a binary (through an archive or fs.FS implementation for example).

@ivokub This is not actually correct. There is a binary "compiled form" for any set of constraints which provides what you want. Specifically, you can run zkc compile -o constraints.bin main.zkc to get a single bin file. Within the existing arithmetisation, there is a Makefile target which does this here.

That said, I think this PR is fine and I am happy to merge it. I just wanted to make sure you knew that this was the original intent.

[DavePearce]

LGTM