feat: enforce minimal trace size - #2190
Merged
Merged
Conversation
DavePearce
force-pushed
the
2157-feat-enforce-minimal-trace-size
branch
from
August 27, 2026 03:38
30770cb to
337071b
Compare
This removes the AllowPadding() flag which is actually not required. Signed-off-by: DavePearce <dave01001110@gmail.com>
This reworks the padding mechanism to ensure that each module has a pre-determined minimum trace size, according to the shift schedule. Specifically, for a maximum negative shift of N and a maximum positive shift of M, we enforce a minimum size of N+M+1. This also removes the notion of "defensive" padding, as this is not really required any more. Specifically, because ZkC has fairly minimal requirements on shifting. This puts through a simple fix for json.Writer which ensures traces can be correctly written out into JSON, even in the presence of static reference tables. Signed-off-by: DavePearce <dave01001110@gmail.com>
This now adds support for printing the trace generated from "zkc trace". The reason for this is simply to aid debugging. Signed-off-by: DavePearce <dave01001110@gmail.com>
DavePearce
force-pushed
the
2157-feat-enforce-minimal-trace-size
branch
from
August 27, 2026 03:39
337071b to
358eb3b
Compare
The initial padding row has been dropped, since this is no longer required. Specifically, its main purpose was to handle lookups with "manual selectors". However, we now have conditional lookups and, hence, no need for this mode. Signed-off-by: DavePearce <dave01001110@gmail.com>
DavePearce
force-pushed
the
2157-feat-enforce-minimal-trace-size
branch
from
August 27, 2026 05:37
358eb3b to
00f2747
Compare
DavePearce
enabled auto-merge (squash)
August 27, 2026 21:36
letypequividelespoubelles
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.