fix: revert back to old register naming - #1053
Merged
DavePearce merged 2 commits intoJul 29, 2025
Merged
Conversation
This puts back in place the old register naming.
A number of perspective-related tests were now failing due to the change in column naming. Specifically, because the wrong names were being used in accepts/rejects files leading to "missing column in trace" errors, etc.
DavePearce
force-pushed
the
1052-feat-use-old-perspective-naming-for-v10-line
branch
from
July 29, 2025 21:54
0d24c87 to
ed6d953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to revert the naming for columns to how it was under
v1.0.8, in order to ensure compatibility with the existing mainnet setup (which usesv1.0.8and a corresponding tracer). Specifically, column names will not include perspective names. This is clearly suboptimal as it can (potentially) lead to name clashes. However, such clashes are always reported as duplicated column errors.