feat: IsZero, IsOne, tests - #1042
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces IsZero and IsOne utility functions to field elements across multiple field implementations, along with comprehensive test coverage. The changes also refactor the Montgomery representation constants and improve the NewElement function implementation.
- Adds
IsZeroandIsOnemethods to field element implementations - Refactors constant naming from
rSqtorSqModMand introducesrModMconstant - Updates
NewElementimplementation to use multiplication instead of modular arithmetic
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/util/field/interface.go | Adds IsZero and IsOne methods to the Element interface |
| pkg/util/field/interface_test.go | New test file to verify interface compliance |
| pkg/util/field/internal/generator/main.go | Updates field configuration to generate both rModM and rSqModM constants |
| pkg/util/field/internal/generator/templates/*.tmpl | Template updates for new constants and methods |
| pkg/util/field/*/element.go | Implements IsZero/IsOne methods and refactors constants across field types |
| pkg/util/field/*/element_test.go | Adds comprehensive tests for zero/one properties and algebraic operations |
| pkg/util/assert/assert.go | Adds True and False assertion helpers |
Tabaie
marked this pull request as ready for review
July 28, 2025 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsZeroandIsOneNewElementby taking out the% moperation.NewElementtoNew.