feat: sanity checks for lookup vectors - #1037
Merged
Merged
Conversation
This puts in place some sanity checks for lookup vectors, such as looking for potentially negative coordinates.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if vector.HasSelector() { | ||
| // Determine value range of ith term | ||
| valrange := vector.Selector.Unwrap().ValueRange(modmap) | ||
| // Determine bitwidth for that range |
There was a problem hiding this comment.
Bug: Vector Lookup Bugs: Mismatched Lengths, Nil Terms
The checkLookupVector function contains two bugs:
- It can panic with an index out of bounds error when iterating
vector.Termsand accessingterms[i], as the lengths ofvector.Terms(translatedmir.Terms) andterms(originalast.Exprs) are not guaranteed to match. - It can panic with a null pointer dereference when calling
ValueRange()on elements ofvector.Termsor onvector.Selector.Unwrap(). This occurs if prior translation steps (translateUnitExpressionsortranslateExpression) resulted innilmir.Terms being included in thevector.
Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts in place some sanity checks for lookup vectors, such as looking for potentially negative coordinates.