Skip to content

feat: tweak internal representation of lookups - #1036

Merged
DavePearce merged 8 commits into
mainfrom
969-feat-tweak-internal-representation-of-lookups
Jul 28, 2025
Merged

feat: tweak internal representation of lookups#1036
DavePearce merged 8 commits into
mainfrom
969-feat-tweak-internal-representation-of-lookups

Conversation

@DavePearce

Copy link
Copy Markdown
Contributor

No description provided.

This refactors constraints so they will within their own folders.
This refactors the existing lookup.Constraint to make use of
lookup.Vector rather than a raw array of terms.  This makes many things
easier to understand.
This fixes encoding / decoding of lookup vectors, and additionally adds
some improved handling of panics during constraint checking.
@DavePearce DavePearce linked an issue Jul 28, 2025 that may be closed by this pull request
Comment thread pkg/ir/mir/lookup.go
Comment thread pkg/schema/schemas.go
Comment thread pkg/ir/mir/lookup.go
Comment thread pkg/schema/constraint/lookup/constraint.go
@DavePearce
DavePearce force-pushed the 969-feat-tweak-internal-representation-of-lookups branch from 3181074 to ad0dd80 Compare July 28, 2025 02:35
This just makes the error handling code a little more robust.
@DavePearce
DavePearce force-pushed the 969-feat-tweak-internal-representation-of-lookups branch from ad0dd80 to e03280c Compare July 28, 2025 02:38
Comment thread pkg/ir/mir/lookup.go
@DavePearce
DavePearce merged commit b296c3f into main Jul 28, 2025
4 checks passed
@DavePearce
DavePearce deleted the 969-feat-tweak-internal-representation-of-lookups branch July 28, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: tweak internal representation of lookups

1 participant